[fix flaky on mki] add dismiss all toasts #184659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
cnasikas
approved these changes
Jun 3, 2024
| @@ -258,6 +259,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { | |||
| createNCasesBeforeDeleteAllAfter(1, getPageObject, getService); | |||
|
|
|||
| it('deletes a case correctly', async () => { | |||
| await toasts.dismissAll(); | |||
There was a problem hiding this comment.
I am wondering if we should do it before each test. Wdyt?
There was a problem hiding this comment.
If you'd like to, please update this branch, so we can git it in quicker.
I don't see the harm in it, personally.
There was a problem hiding this comment.
If we are in a rush to merge this PR then it is better to leave it as it is. In case it was not clear what I meant by "before each test" was something like
beforeEach(async () => {
await toasts.dismissAll();
}
|
🚨 |
|
@elasticmachine merge upstream |
…_suites-observability-cases-list_view
|
@elasticmachine merge upstream |
…_suites-observability-cases-list_view
|
@elasticmachine merge upstream |
…_suites-observability-cases-list_view
|
@elasticmachine merge upstream |
…_suites-observability-cases-list_view
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
wayneseymour
deleted the
fixup-x-pack-test_serverless-functional-test_suites-observability-cases-list_view
branch
rohanxz
pushed a commit
to honeyn303/kibana
that referenced
this pull request
Jun 4, 2024
## Summary resolves: elastic#184655 Ran this from my local, against an MKI oblt cluster. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves: #184655
Ran this from my local, against an MKI oblt cluster.